On Thu, Mar 15, 2012 at 4:35 PM, Phil Charlesworth <[email protected]> wrote: > On 15/03/12 15:35, lkcl luke wrote: >> On Thu, Mar 15, 2012 at 3:18 PM, Phil Charlesworth >> <[email protected]> wrote: >> >>> Lex, >>> I notice you have posted an amendment to re.findall(). I was just >>> about to do the same. >>> >>> I agree that groups need to be taken into account but I think that your >>> code will fail if the regular expression doesn't define any groups. I >>> have just tested it on an example from the Python 2.6.4 docs for the re >>> module. >>> >> can you please add that as a test, to LibTest? really we should have >> the complete test_re.py stuff, and be able to run it, but that's >> another story. >> >> l. > Will have a go at LibTest, if we can agree he new version, unless Lex > wants to do it.
tests should just be added, period. regardless of the code that they're testing. you should not wait until the code is written (correct or otherwise). tests come first. code later. l.
