On Jul 7, 4:56 pm, Kyle VanderBeek <[email protected]> wrote: > On Jul 7, 4:23 pm, Mike Orr <[email protected]> wrote: > > > I don't want to get into a bikeshed argument over changing one local > > variable from three letters to nine. I just want to point out that > > there is opposition to the change, and that the status quo should get > > the benefit of the doubt. > > I don't want to make a big deal out of it either. My only argument is > that the status quo in this case may cause a problem for someone using > the template that spits out routing.py in a new project. If they > actually do want to use map() later on as they develop their make_map > (), they're going to get a potentially confusing exception that > routes.base.Mapping doesn't implement __call__(). If we want to > improve Pylons and help people have success with it, side stepping > such confusion is arguably a Good Thing (TM), especially since it is > just template code and doesn't cause any interface/compatibility > problems.
I agree to a certain extent, but someone that doesn't know `map` is a built-in will probably get bit by that eventually anyway, beside the fact that they SHOULD be using list comprehensions. ;) If I had to vote on a change to `route_map`, I'd vote +0. > As for the length, yes, I actually do use variables like that all the > time. My code reads like English, and the people who maintain it love > that. :-) I agree with this sentiment, too, but there is an argument to be made for reducing verbosity if doing so doesn't impact understanding too much. It's possible to be overwhelmed by LOC, and single logical lines of code spread over multiple lines are harder to read (and there's that whole pesky question of how to best format such lines, leading to further bike shed discussions...) I say we add a class called Kernel and shove all the built-ins into it. You know, so it'll be all "object-oriented" and stuff. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pylons-discuss" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/pylons-discuss?hl=en -~----------~----~----~----~------~----~------~--~---
