On Tue, Sep 22, 2009 at 10:36 PM, Qiangning Hong <[email protected]> wrote: > > On Wed, Sep 23, 2009 at 1:17 PM, Mike Orr <[email protected]> wrote: >> >> On Tue, Sep 22, 2009 at 8:06 PM, Jonathan Vanasco <[email protected]> >> wrote: >>> >>> by default it sets response.content_type to "application/json" >>> >>> is there a way to override this? >>> if not , could I request this in a future version of pylons ? >>> >>> though testing, i discovered that a lot of browsers will 'download' >>> application/json files if you hit them directly -- ie, they won't >>> render in the browser, they'll just save to disk. >>> >>> the same browsers will render "text/javascript" files fine. >>> >>> i've got some custom code that lets me dev stuff, but something built >>> into pylons would probably be useful for others. >> >> I don't quite grok decorators, but it looks like it would have to be a >> separate function. The signature is jsonify(func, *args, **kw), so >> there's no place to add a content-type argument. > > I'd like to make jsonify more smart: use pylons.config['debug'] to > decide to serve as application/json or text/javascript. i.e. > text/javascript only under debug environment for easier debugging, > otherwise the more standard application/json.
This sounds too magical. While we want to be flexible for debugging, we don't want to make too many differences between the development and production behavior. It sounds like the current implementation is fine, and users can override the content-type in their action. Another possibility would be a magic keyword arg 'content_type', although that doesn't seem necessary. But I get confused between the decorator's arguments and the wrapped function's arguments. You'd really want that to be a decorator argument, but I'm not sure if you can do that with the 'decorator' decorator. But at the same time, only the action itself has the proper context to decide which content-type is appropriate for the situation. So that would argue for the present practice of overriding the content-type in the action. -- Mike Orr <[email protected]> --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pylons-discuss" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/pylons-discuss?hl=en -~----------~----~----~----~------~----~------~--~---
