On Wed, 2011-06-22 at 09:28 +0200, Robert Forkel wrote: > Hi Chris, > I read your commit comment, and think it is a bit ambiguous. While it > is true, that translation directories added later will be found > earlier in i18n.make_localizer, this doesn't mean that messages > defined in these will trump messages defined in translation > directories added earlier (at least if i understand the add/merge > methods of Translations in i18n correctly). > It's probably less confusing, when the behaviour under the hood is > just ignored, and the docs state: messages defined in translation dirs > added earlier take precedence over the ones in catalogs added later.
Actually, I've decided to just leave it undefined, it's not relevant to the bug that was fixed. https://github.com/Pylons/pyramid/commit/b0c075ce8eeb7cb95188c1f41feca7af42bb46c7 > regards, > robert > > On Wed, Jun 22, 2011 at 9:09 AM, Chris McDonough <[email protected]> wrote: > > On Tue, 2011-06-21 at 23:41 -0700, Robert Forkel wrote: > >> Hi all, > >> in my pyramid application i make use of additional translation > >> directories provided by plugins to override messages defined in the > >> default translation. So i have to rely on the order of translation > >> directories. To make sure this can be relied upon, i looked through > >> the pyramid code and found that in i18n.make_localizer the order of > >> translation directories is reversed compared to the order i specified > >> in my Configurator.add_translation_dirs call. It seems to get reversed > >> in the queryUtility. I don't have a problem with this but wanted to > >> know, whether this behaviour can be relied upon. > >> best regards, > >> robert > > > > I've changed the behavior on the master branch (what will become 1.1) to > > add the directories in the order provided when multiple directories are > > fed to add_translation_dirs: > > > > https://github.com/Pylons/pyramid/commit/6ed33ec54b0dae6ae2a38a0c7a6d383e2ac1967e > > > > Definitely call add_translation_dirs multiple times to preserve forward > > compatibility as a result. > > > > Thanks! > > > > - C > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "pylons-discuss" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]. > > For more options, visit this group at > > http://groups.google.com/group/pylons-discuss?hl=en. > > > > > -- You received this message because you are subscribed to the Google Groups "pylons-discuss" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pylons-discuss?hl=en.
