On Mon, Mar 6, 2017 at 10:56 AM, Jonathan Vanasco <[email protected]> wrote:
> two comments: > > 1. have you considered marking `pyramid_tm` as end-of-life, and pushing > for the new changes as `pyramid_transaction` or some other uniquely > different name? > Mikko already commented on this but I'll reiterate that if we renamed the library every time we wanted to change part of the design the maintenance nightmare would be unsustainable. Version numbers are the best way we have to progress the library and communicate the changes to the users. The changes being made here are almost all fixing *broken* features in pyramid_tm and are in the spirit of the library. If we were changing the entire purpose of the library then a rename would be in order. The main incompatibility is the position of the tween in the order... it is now over exception views instead of under. That means if you have hacks in your app to do database things in your exception views... I'm warning you that may break. The retry stuff was fundamentally broken before in anything except the simplest apps. > 2. it might make sense to have deployment advice recommend people install > `pyramid_tm` etc as <2.0 and then <3.0 (or some other number) for future > compatibility issues. > This is basic advice that applies to every library ever written. The only thing that matters is to understand the library's versioning scheme which, admittedly, we may not do a great job explaining for the Pylons projects. For most of our projects we will update the major version number for a breaking change... Pyramid core is slightly different but it also puts a much larger emphasis on deprecation periods and maintaining older versions. We could always talk about improving this process in the future, but this isn't the place to do it. > I've been bitten by large API changes like this before. Not from Pyramid, > but other projects where some 3rd party library updates another 3rd party > library to an incompatible version. It's a giant pain. > Yes, it is a giant pain. That's why I wanted to warn people explicitly in this case because I don't want anyone suffering dataloss because their transaction manager changed. -- You received this message because you are subscribed to the Google Groups "pylons-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/pylons-discuss/CAKdhhwFhhCvW6hOtAr0G3mDFiPBBN%3DYDMtRqpMPk710JMJAJ1w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
