> Am 14.08.2018 um 14:03 schrieb Vincent Favre-Nicolin <fa...@esrf.fr>:
> 
>               Hi Andreas,
> 
>       I tested this against my code and found only one issue when using 
> gpyfft, as the ‘retain’ keyword argument seems to be absent in the new 
> Event.from_int_ptr() function.
> 
>       If I remove the ‘retain=False’ argument near the end of gpyfftlib.pyx 
> everything works as before. Not sure how necessary the retain argument is 
> (Gregor ?).

Hi,

it seems it is a regression that in the latest pyopencl version the retain 
argument to Event.from_int_ptr() is missing. It has been added to avoid a 
memory leak, see https://github.com/inducer/pyopencl/issues/113

best
Gregor

> 
>       The tests use a lot of reduction, elementwise, and FFT (through gpyfft) 
> kernels with moderately large arrays (multiple stacks of 16x400x400 floats), 
> and I see no significant speed change (no tight-kernel-calling loops, sorry 
> !). Looks good !
> 
>       Cheers,
> -- 
> Vincent Favre-Nicolin
> 
> 

_______________________________________________
PyOpenCL mailing list
PyOpenCL@tiker.net
https://lists.tiker.net/listinfo/pyopencl

Reply via email to