Gregor Thalhammer <gregor.thalham...@gmail.com> writes: >> Am 14.08.2018 um 19:02 schrieb Andreas Kloeckner <li...@informa.tiker.net>: >> >> Gregor, Vincent, >> >> Gregor Thalhammer <gregor.thalham...@gmail.com >> <mailto:gregor.thalham...@gmail.com>> writes: >>>> Am 14.08.2018 um 14:03 schrieb Vincent Favre-Nicolin <fa...@esrf.fr>: >>>> >>>> Hi Andreas, >>>> >>>> I tested this against my code and found only one issue when using >>>> gpyfft, as the ‘retain’ keyword argument seems to be absent in the new >>>> Event.from_int_ptr() function. >>>> >>>> If I remove the ‘retain=False’ argument near the end of gpyfftlib.pyx >>>> everything works as before. Not sure how necessary the retain argument is >>>> (Gregor ?). >>> >>> Hi, >>> >>> it seems it is a regression that in the latest pyopencl version the >>> retain argument to Event.from_int_ptr() is missing. It has been added >>> to avoid a memory leak, see >>> https://github.com/inducer/pyopencl/issues/113 >> >> Thanks for taking a look, and for catching this regression. I've added >> the retain flag in 88eecd2. > > Thanks for fixing this. Did you push it to the github repo? Can’t see it.
I can see them on the pybind11 branch: https://github.com/inducer/pyopencl/pull/240 Andreas
signature.asc
Description: PGP signature
_______________________________________________ PyOpenCL mailing list PyOpenCL@tiker.net https://lists.tiker.net/listinfo/pyopencl
