Hi Antonio Antonio Cuni wrote: > I've spent last days working on this topic: I tried to refactor the code > for making rlist type-system specific as rtuple, rclass and others > already was. > It has been a bit difficult because it was my first hacking in the > rpython directory: I had to read the sources carefully for understanding > in deep how things works, and I'm not sure if I have completely > understood the whole logic. > > I've just committed my work in the > http://codespeak.net/svn/user/antocuni/pypy-antocuni directory. I'm not > satisfied of it because it is a bit messy and I'm happy to know that now > it's no longer needed because yours is surely better :-). By the way I > think it has not been a waste of time because it let me to gain some > knowledge of pypy's internals that will be useful in future.
Oops, I didn't intend to invalidate your work. ;) I actually checked your user directory yesterday, because you said in an earlier mail that you would work on the branch there. But since I didn't see any changes related to rlist I assumed you decided to postpone this ... What you did doesn't look so bad, I just looked at it. In general, I'm impressed that you found your way around the RTyper so easily. ;) The main difference to our work is that you created many new low-level operations for the list interface. Since there will also have to be a dict and string interface this would lead to an explosion of low-level operations. Our approach also makes testing of these data structures at a lower level easier (see test_oolist.py and test_oortype.py). > Sure, I'll be happy to continue from here: it is much better than > starting from scratch as I supposed to do! :-) > I think you've saved me from a lot of headaches, thanks! Remind me to > offer you a beer the first time we meet ;-). Hehe, looking forward to that. ;) Cheers Nik _______________________________________________ pypy-dev@codespeak.net http://codespeak.net/mailman/listinfo/pypy-dev
