If someone is alread working at this, please ignore this mail: I just
picked because it was ease enough not to do while I wait some other
code to run at work.
I've created two patches to p3yk. They are two alternatives to fix the
broken test_dict.py:
test_dict_1.patch uses the same approach as test_dictviews.py:
transform the dict_view in a set.
test_dict_2.patch is an alternative: I'm not sure if the .items(),
.values() and .keys() should be covered two times (test_dict.py and
test_dictviews.py), so this solves the problem removing this tests
from test_dict.py.
--
EduardoOPadoan (eopadoan->altavix::com)
Bookmarks: http://del.icio.us/edcrypt
Index: test_dict.py
===================================================================
--- test_dict.py (revisão 53776)
+++ test_dict.py (cópia de trabalho)
@@ -19,7 +19,7 @@
def test_keys(self):
d = {}
- self.assertEqual(d.keys(), [])
+ self.assertEqual(set(d.keys()), set())
d = {'a': 1, 'b': 2}
k = d.keys()
self.assert_('a' in d)
@@ -29,18 +29,18 @@
def test_values(self):
d = {}
- self.assertEqual(d.values(), [])
+ self.assertEqual(set(d.values()), set())
d = {1:2}
- self.assertEqual(d.values(), [2])
+ self.assertEqual(set(d.values()), {2})
self.assertRaises(TypeError, d.values, None)
def test_items(self):
d = {}
- self.assertEqual(d.items(), [])
+ self.assertEqual(set(d.items()), set())
d = {1:2}
- self.assertEqual(d.items(), [(1, 2)])
+ self.assertEqual(set(d.items()), {(1, 2)})
self.assertRaises(TypeError, d.items, None)
Index: test_dict.py
===================================================================
--- test_dict.py (revisão 53776)
+++ test_dict.py (cópia de trabalho)
@@ -17,33 +17,6 @@
self.assert_(bool({}) is False)
self.assert_(bool({1: 2}) is True)
- def test_keys(self):
- d = {}
- self.assertEqual(d.keys(), [])
- d = {'a': 1, 'b': 2}
- k = d.keys()
- self.assert_('a' in d)
- self.assert_('b' in d)
-
- self.assertRaises(TypeError, d.keys, None)
-
- def test_values(self):
- d = {}
- self.assertEqual(d.values(), [])
- d = {1:2}
- self.assertEqual(d.values(), [2])
-
- self.assertRaises(TypeError, d.values, None)
-
- def test_items(self):
- d = {}
- self.assertEqual(d.items(), [])
-
- d = {1:2}
- self.assertEqual(d.items(), [(1, 2)])
-
- self.assertRaises(TypeError, d.items, None)
-
def test_contains(self):
d = {}
self.assert_(not ('a' in d))
_______________________________________________
Python-3000 mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-3000
Unsubscribe:
http://mail.python.org/mailman/options/python-3000/archive%40mail-archive.com
