Eli Bendersky <eli...@gmail.com> added the comment: >> From a performance point of view, consider the (by far) common case >> - where _elementtree *is* successfully imported. >> ... for each invocation, the whole import of the Python code has >> to be done, just to reach the overriding import * at the end. > > This point is wrong... the _elementtree.c accelerator imports Python > ElementTree already. > > As you can see on lines 2938 to 2945, the change could lead to an import > cycle: > http://hg.python.org/cpython/file/705b56512287/Modules/_elementtree.c#l2938 > > Trying to sort this out, it already gives me a headache. > I would like to remove the Python bootstrap code from the C module and try to > do it differently, in a more standard way. >
The Python code inside _elementtree could be moved to Python code, which would then import the Python stuff it needs from pyElementTree. Since pyElementTree doesn't import _elementtree, there will be circular dependencies. So this is a point *in favor* of pyElementTree being pure-Python :-) In other words: In xml/etree there is: - ElementTree: tries to import cElementTree. On success, done. On ImportError, imports pyElementTree - pyElementTree: the pure Python implementation - cElementTree: sets up the bootstrap Python code and tries to import _elementtree. In case of an error, propagates an ImportError up. Would that work? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue13988> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
