Chris Jerdonek added the comment:

Thanks, Chris.  A couple high-level comments.

I know this isn't the prevailing style of the existing tests, but it's 
generally better if each unit test tests just one thing.  That way, for 
example, if a test fails you know more precisely what is not working.

Would it be possible to structure things so that you have tests like 
test_report(), test_report_partial_closure(), etc?

Also, is there any reason you need to be using a regular expression as opposed 
to an exact string match?

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15518>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to