Chris Calloway added the comment: I replaced issue-15518-1.patch. I believe it now addresses all the concerns expressed thus far. If reviewed favorably, I will extend it to clean-up the pre-existing tests to address the concerns noted about them, especially since the filecmpdata directory added by this patch contains the information necessary to test the rest of the filecmp module rather than resorting to creating temp directories and files. It seems less than ideal to me to have the test script use a mixed model for accessing test data (both temp and filecmpdata directories). But that's not my call.
---------- Added file: http://bugs.python.org/file29758/issue-15518-1.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue15518> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
