Chris Calloway added the comment: I'm uploading a new patch which gets rid of the temp_cwd calls as suggested in the review. The patch is not complete in that the explanatory comments suggested in the review and revising the pre-existing tests have not been completed yet. However, I want to upload the work I do have as it has been a couple of weeks since reivew and I won't have another opportunity to complete the review suggestions until PUG project nights on May 7th and 8th.
Also, I'm uploading this new patch because the previous patch had a serious problem that caused this delay. I happened to get a new laptop and used the previous patch to recreate the tests. I found that part of the new filecmpdata directory was missing when I did that and some of the tests failed as a result. It turns out that hg add and hg diff were not detecting all of filecmpdata. There's a well known problem with hg no detecting empty directories. However, this was not the case in this patch. Because I was able to workaround the problem by recreating all the dir-same directories and all their subdirectories, I think the problem is with hg not detecting directories with identical contents if the creation dates are the same. It's something I'll need to investigate more when this issue has been completed. ---------- Added file: http://bugs.python.org/file30040/issue-15518-1.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue15518> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
