STINNER Victor added the comment: fastcalldict.patch avoided INCREF/DECREF on keyword keys and values. This is wrong: we must hold strong references because the keyword dictionary can be technically modified: see issue #2016 and test_extcall.
Hum, I'm quite sure that it's not the first time that I was bitten by this bug. That's maybe why I didn't try to implement this optimization the first time. fastcalldict-2.patch keeps INCREF/DECREF and so doesn't crash on test_extcall. ---------- Added file: http://bugs.python.org/file45704/fastcalldict-2.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28839> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
