STINNER Victor added the comment:

So, what do you think of renaming argument like:

* Replace "callable_object" and "func" with "callable"
* Replace "method" with "name"
* Rename "o" to "obj" (ex: in "PyCallable_Check(PyObject *o)")

I prefer "callable_object" over "callable" because it's shorter. Some functions 
already use "callable" (and so others use "callable_object").


Eric: ""Isn't this just a lot of churn for not a lot of benefit? I'm all for 
consistency, but you'll break patches on the bug tracker and externally 
maintained patches."

I'm not aware of any pending patch on "call" functions like PyObject_Call. I 
think that I am the latest who modified these functions. I'm working on a new 
patch serie to add support for fast calls in tp_call. That's why I would prefer 
to uniformize argument names first, before rebasing my large patch.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28838>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to