Serhiy Storchaka added the comment:

LGTM, but I prefer `overflow > 0` over `overflow == 1`.

If use _testcapi the tests should be decorated with cpython_only. But I think 
that it is better to not use it. Limiting _length_ to C long (rather than 
size_t) is an implementation detail. The test with _length_ = 1 << 1000 should 
be enough.

----------
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
stage:  -> patch review

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29843>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to