Oren Milman added the comment: here is the patch updated according to your suggestions, Serhiy.
however, I wonder about the case of a too large _length_. shouldn't we raise a MemoryError in such a case, in accordance with #29833? BTW, while inspecting code related to a too large _length_, I came across this (in PyCArrayType_new): if (length * itemsize < 0) { PyErr_SetString(PyExc_OverflowError, "array too large"); goto error; } I am not sure, but isn't this check unsafe? (e.g. if length == 2 ** 30, and itemsize == 4, couldn't the product be 0 on some platforms?) but maybe the code before this check makes more checks. I didn't make a thorough inspection... ---------- Added file: http://bugs.python.org/file46735/patchDraft2.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29843> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com