On 12 April 2017 at 03:10, Mariatta Wijaya <mariatta.wij...@gmail.com> wrote: > Back to the original issue with reviewing the PR > https://github.com/python/cpython/pull/851 > > Other than not being able to review the diff, is there any other problem? > Can the PR be reviewed as is? > > Martin, you said: "I’m not really set up to properly review and push stuff > with the new Git Hub setup," > Are you wanting to make edits to the PR yourself? > If so, maybe you can try these instructions: > http://cpython-devguide.readthedocs.io/gitbootcamp.html#editing-a-pull-request-prior-to-merging
At the moment I don’t have the setup nor time to spend on this, sorry. If I were in a position to download the pull request and properly review and test it out, I may want to negotiate changes with the original contributor, or failing that, make edits myself, but i’m not intending to do this right now. > On Tue, Apr 11, 2017 at 11:30 AM, Terry Reedy <tjre...@udel.edu> wrote: >> I think committers should always be responsible for the commit message. >> This will usually mean editing submissions from non-committers. Since >> message is truncated to first line in some displays, the latter should >> summarize main point of commit. _______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
