On 4/10/2017 11:55 PM, Martin Panter wrote:
On 11 April 2017 at 13:13, Mariatta Wijaya <mariatta.wij...@gmail.com> wrote:
"View Changes" doesn't work when commits in PR were squashed, which seems to
be the case in https://github.com/python/cpython/pull/851
I wonder if there is a way to unsquash the commits? Will it help with
reviewing this PR?
In this particular pull request, I think the submitter has rebased
their commit, and force-pushed it. These days, I notice Git Hub seems
to forget old commits pretty soon after you force-push the branch they
are on. I don't think you can "unsquash" them retrospectively; you
would need a copy of the old commits saved somewhere.
Other times people add revised commits on top of their old commits,
which would have been easier for me in this situation, but I suspect
that makes it harder for the person pushing the final change if they
have to squash it into a single commit. (I noticed the eventual commit
message is often messy, redundant, automatically generated, etc.)
I was under the impression that the green [commit] button would do the
squashing. Or at least that it could.
tjr
_______________________________________________
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/
