Hi David, I cannot comment on the PR, but since the functionality is asyncio-specific, I would suggest moving it to a dedicate `asyncio.testing` module, or something similar, rather than leaving it in `unittest` proper.
Regards Antoine. On Tue, 5 Feb 2019 07:05:05 -0500 David Shawley <daveshaw...@gmail.com> wrote: > Hi everyone, I added a PR to add a sub-class of unittest.TestCase that makes > it possible to write async test methods. I wrote this a few months ago and > it is waiting on core review. Is there a core dev that can take up this > review? I would love to have this functionality in the core. > > Lukasz - should we add this to Python 3.8 or is it too late for feature > additions? > > BPO link: https://bugs.python.org/issue32972 > <https://bugs.python.org/issue32972> > Github PR: https://github.com/python/cpython/pull/10296 > <https://github.com/python/cpython/pull/10296> > > cheers, dave. > -- > "State and behavior. State and behavior. If it doesn’t bundle state and > behavior in a sensible way, it should not be an object, and there should not > be a class that produces it." eevee > > _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
