On Thu, Feb 14, 2019 at 3:25 PM Eric Snow <ericsnowcurren...@gmail.com>
wrote:
> On Thu, Feb 14, 2019, 02:47 Ronald Oussoren via Python-Dev <
> python-dev@python.org wrote:
>
>>
>> I usually use shutil.rmtree for tests that need to create temporary
>> files, and create a temporary directory for those files (that is, use
>> tempfile.mkdtemp in setUp() and use shutil.rmtree in tearDown()). That way
>> I don’t have to adjust house-keeping code when I make changes to test code.
>>
>
> Same here.
>
> -eric
>
>>
What I generally do is avoid relying on tempfile.mkdtemp() and always use
TESTFN instead. I think it's cleaner as a pradigm because it's an incentive
to not pollute the single unit tests with `self.addCleanup()` instructions
(the whole cleanup logic is always supposed to occur in setUp/tearDown):
TESTFN = support.TESTFN
TESTFN2 = TESTFN + '2'
class FilesystemTest(unittest.TestCase):
def setUp(self):
remove_file_or_dir(TESTFN)
remove_file_or_dir(TESTFN2)
tearDown = setUp
def test_mkdir(self):
...
def test_listdir(self):
...
def test_rename(self):
...
--
Giampaolo - http://grodola.blogspot.com
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
