> On 2 Jul 2020, at 21:38, Chris Angelico <ros...@gmail.com> wrote: > > Formal proposal: Either request a new commit message from the original > author, or have someone rewrite it, and we go ahead and make the > change.
-1 This would be serious precedent to fiddling with publicly replicated repo history. This would require coordination with project admins as force-pushes are rightfully disabled for our repositories. Commit messages aren't usually scrutinized to this extent. If you looked at the last 1000 commits in cpython, you'd find quite a few with messages that could be seriously improved. We don't though because commits are immutable. You can revert them but we never downright replace them with different ones. Otherwise what's the point in me signing release tags? Is the commit message perfect? No. Is the intent explained better on the linked PR? Yes. Is the change itself good? Also yes. Formal proposal: leave this alone. - Ł _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/RED5C5ML2BIOS4RZ23O7M2D3WZKUSPCW/ Code of Conduct: http://python.org/psf/codeofconduct/
