Ben Finney wrote:
...

        def assert_compare_true(op, first, second, msg=None):
            if msg is None:
                msg = "%(first)r %(op)r %(second)" % vars()
            if not op(first, second):
                raise self.failure_exception(msg)

I would rather something more like:

      def assert_compare_true(op, first, second, msg=None):
          if op(first, second):
              return
          raise self.failure_exception(msg)
          if msg is None:
              self.failure_exception("%(first)r %(op)r %(second)"
                                         % vars())
          self.failure_exception("%(first)r %(op)r %(second): %(msg)"
                                 % vars())


--Scott David Daniels
[EMAIL PROTECTED]

_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Reply via email to