Alexander Belopolsky wrote: > On Tue, Nov 16, 2010 at 10:38 AM, M.-A. Lemburg <m...@egenix.com> wrote: > .. >> One API I'm not sure about is PyUnicode_AppendAndDel(). It's somewhat >> obscure and given that we already have PyUnicode_Concat(), I think >> it should be made private and eventually dropped. >> > > What about PyUnicode_GetMax()? Isn't that supposed to be > Py_UNICODE_GETMAX()? Or better still Py_UNICODE_MAXORDINAL?
Traditionally, all uppercase symbols refer to macros, whereas the mixed case ones refer to functions. Now, we can't use a macro for this, since the information has to be available as callable in order to applications or extensions to use it (without recompile). Regarding the name: PyUnicode_MaxOrdinal() would certainly have been better. BTW: I'm not really happy about the Py_UNICODE_ prefix for functions in unicodeobject.h, but I guess it's too late to change those. It would be better to stick to one prefix for Unicode related APIs, i.e. "PyUnicode_". -- Marc-Andre Lemburg eGenix.com Professional Python Services directly from the Source (#1, Nov 16 2010) >>> Python/Zope Consulting and Support ... http://www.egenix.com/ >>> mxODBC.Zope.Database.Adapter ... http://zope.egenix.com/ >>> mxODBC, mxDateTime, mxTextTools ... http://python.egenix.com/ ________________________________________________________________________ ::: Try our new mxODBC.Connect Python Database Interface for free ! :::: eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48 D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg Registered at Amtsgericht Duesseldorf: HRB 46611 http://www.egenix.com/company/contact/ _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com