-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/06/2011 04:37 PM, Antoine Pitrou wrote: > On Wed, 6 Apr 2011 13:22:09 -0700 > Brett Cannon <br...@python.org> wrote: >> On Wed, Apr 6, 2011 at 12:45, Raymond Hettinger <raymond.hettin...@gmail.com >>> wrote: >> >>> >>> On Apr 6, 2011, at 10:39 AM, Brett Cannon wrote: >>>> Since people are taking my "semantically identical" point too strongly >>> for what I mean (there is a reason I said "except in cases >>>> where implementation details of a VM prevents [semantic equivalency] >>> entirely"), how about we change the requirement that C acceleration code >>> must pass the same test suite (sans C specific issues such as refcount tests >>> or word size) and adhere to the documented semantics the same? It should get >>> us the same result without ruffling so many feathers. And if the other VMs >>> find an inconsistency they can add a proper test and then we fix the code >>> (as would be the case regardless). And in instances where it is simply not >>> possible because of C limitations the test won't get written since the test >>> will never pass. >>> >>> Does the whole PEP just boil down to "if a test is C specific, it should be >>> marked as such"? >>> >> >> How about the test suite needs to have 100% test coverage (or as close as >> possible) on the pure Python version? > > Let's say "as good coverage as the C code has", instead ;)
The point is to require that the *Python* version be the "reference implementation", which means that the tests should be fully covering it (especially for any non-grandfathered module). Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2c48QACgkQ+gerLs4ltQ4p2ACgjds89LnzLnSEZOykwZKzqFVn VVAAn10q1x74JOW2gi/DlYDgf9hkRCuv =ee3b -----END PGP SIGNATURE----- _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
