To clarify, now that I have access to an actual keyboard instead of just a cellphone: I think it should be rolled back, since the proper process for controversial changes was not followed. Our process (part of our culture, if you will) for anything controversial is to discuss the change first, then, if deemed necessary, fix the code. And from the size of this thread it clearly is controversial. Georg, can you please revert this change?
Note that another part of our process/culture is that we try not to engage in battling commits, i.e. generally we don't unilaterally roll back a change just to make the point that it is incorrect; we ask the original committer to roll it back. As to the controversy itself, if you want to make blind people fell more at home in the Python community surely there are more useful things to do than to remove puns involving blindness; e.g. improve accessibility of python.org or some part of it. Or maybe find some blind programmers and ask them what would help them. --Guido On Tue, Jul 5, 2011 at 3:50 PM, Guido van Rossum <gu...@python.org> wrote: > It's not a bug and shouldn't be "fixed". We leave lots of minor infractions > in the code because the code churn of fixing them all would be too > distracting. > > On Jul 3, 2011 10:22 AM, "georg.brandl" <python-check...@python.org> wrote: >> http://hg.python.org/cpython/rev/76452b892838 >> changeset: 71146:76452b892838 >> parent: 71144:ce52310f61a0 >> user: Georg Brandl <ge...@python.org> >> date: Sun Jul 03 19:22:42 2011 +0200 >> summary: >> Remove mention of medical condition from the test suite. >> >> files: >> Lib/test/test_csv.py | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) >> >> >> diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py >> --- a/Lib/test/test_csv.py >> +++ b/Lib/test/test_csv.py >> @@ -459,20 +459,20 @@ >> '5', '6']]) >> >> def test_quoted_quote(self): >> - self.readerAssertEqual('1,2,3,"""I see,"" said the blind man","as he >> picked up his hammer and saw"', >> + self.readerAssertEqual('1,2,3,"""I see,"" said the happy man","as he >> picked up his hammer and saw"', >> [['1', '2', '3', >> - '"I see," said the blind man', >> + '"I see," said the happy man', >> 'as he picked up his hammer and saw']]) >> >> def test_quoted_nl(self): >> input = '''\ >> 1,2,3,"""I see,"" >> -said the blind man","as he picked up his >> +said the happy man","as he picked up his >> hammer and saw" >> 9,8,7,6''' >> self.readerAssertEqual(input, >> [['1', '2', '3', >> - '"I see,"\nsaid the blind man', >> + '"I see,"\nsaid the happy man', >> 'as he picked up his\nhammer and saw'], >> ['9','8','7','6']]) >> >> >> -- >> Repository URL: http://hg.python.org/cpython > -- --Guido van Rossum (python.org/~guido) _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
