2013/7/23 Christian Heimes <christ...@python.org>: > Am 23.07.2013 07:08, schrieb benjamin.peterson: >> http://hg.python.org/cpython/rev/042ff9325c5e >> changeset: 84804:042ff9325c5e >> branch: 3.3 >> parent: 84789:bb63f813a00f >> user: Benjamin Peterson <benja...@python.org> >> date: Mon Jul 22 22:08:09 2013 -0700 >> summary: >> return NULL here >> >> files: >> Python/dynload_shlib.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> >> diff --git a/Python/dynload_shlib.c b/Python/dynload_shlib.c >> --- a/Python/dynload_shlib.c >> +++ b/Python/dynload_shlib.c >> @@ -91,7 +91,8 @@ >> int i; >> struct stat statb; >> if (fstat(fileno(fp), &statb) == -1) { >> - return PyErr_SetFromErrno(PyExc_IOError); >> + PyErr_SetFromErrno(PyExc_IOError); >> + return NULL; >> } > > PyErr_SetFromErrno() already and always returns NULL. Or do you prefer > to return NULL explicitly?
It might always return NULL, but the compiler sees (PyObject *)NULL when this function returns dl_funcptr. -- Regards, Benjamin _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
