On 24 Jul, 2013, at 8:43, Gregory P. Smith <g...@krypto.org> wrote: > > On Tue, Jul 23, 2013 at 8:46 AM, Ronald Oussoren <ronaldousso...@mac.com> > wrote: > > On 23 Jul, 2013, at 17:36, Christian Heimes <christ...@python.org> wrote: > > > Am 23.07.2013 17:10, schrieb Benjamin Peterson: > >>> PyErr_SetFromErrno() already and always returns NULL. Or do you prefer > >>> to return NULL explicitly? > >> > >> It might always return NULL, but the compiler sees (PyObject *)NULL > >> when this function returns dl_funcptr. > > > > Oh, you are right. I must have missed the compiler warning. How about we > > turn type return and type assignment warnings into fatal errors? > > That's probably possible with a '-Werror=....' argument. But please consider > issue 18211 before unconditionally adding such a flag, as that issue mentions > new compiler flags also get used when compiling 3th-party extensions. > > I guess there needs to be (yet) another CFLAGS_xxx variable in the Makefile > that > gets added to $(CFLAGS) during the build of Python itself, but is ignored by > distutils and sysconfig. > > It seems fair to turn those on in 3.4 and require that third party extensions > clean up their code when porting from 3.3 to 3.4.
In this case its "just" code cleanup, the issue I filed (see above) is for another -Werror flag that causes compile errors with some valid C99 code that isn't valid C89. That's good for CPython itself because its source code is explicitly C89, but is not good when building 3th-party extensions. A proper fix requires tweaking the configure script, Makefile and distutils and that's not really a fun prospect ;-) Ronald > > > Ronald > > > > > Christian > > > > _______________________________________________ > > Python-Dev mailing list > > Python-Dev@python.org > > http://mail.python.org/mailman/listinfo/python-dev > > Unsubscribe: > > http://mail.python.org/mailman/options/python-dev/ronaldoussoren%40mac.com > > _______________________________________________ > Python-checkins mailing list > python-check...@python.org > http://mail.python.org/mailman/listinfo/python-checkins > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/ronaldoussoren%40mac.com _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
