On Sun, 23 Mar 2014 21:43:14 +0100, Antoine Pitrou <solip...@pitrou.net> wrote: > On Sun, 23 Mar 2014 20:47:28 +0100 (CET) > r.david.murray <python-check...@python.org> wrote: > > http://hg.python.org/cpython/rev/ec556e45641a > > changeset: 89936:ec556e45641a > > user: R David Murray <rdmur...@bitdance.com> > > date: Sun Mar 23 15:08:43 2014 -0400 > > summary: > > #20145: assert[Raises|Warns]Regex now raise TypeError on bad regex. > > > > Previously a non-string, non-regex second argument could cause the test > > to always pass. > > It seems like this would be useful to fix in 3.4 too.
You will note that the change got a porting note in What's New. It will only break tests (that are currently no-ops), not code, so I'd be fine with backporting it, but the original issue did not call for that. If we fix it in 3.4, should we fix it in 2.7 as well? --David _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
