What is wrong with "except:" in this specific case? Victor
Le mardi 26 mai 2015, Yury Selivanov <yselivanov...@gmail.com> a écrit : > > > On 2015-05-26 12:26 AM, Terry Reedy wrote: > >> + try: >>> + encoding, lines = detect_encoding(buffer.readline) >>> + buffer.seek(0) >>> + text = TextIOWrapper(buffer, encoding, line_buffering=True) >>> + text.mode = 'r' >>> + return text >>> + except: >>> + buffer.close() >>> + raise >>> >> >> Please do not add bare 'except:'. If you mean 'except BaseException:', >> say so. >> > > try..finally would be even better. > > Yury > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/victor.stinner%40gmail.com >
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
