On Tue, 26 May 2015 08:20:01 +0200, Victor Stinner <victor.stin...@gmail.com> wrote: > What is wrong with "except:" in this specific case?
Nothing is wrong with it from a technical standpoint. However, if we use 'except BaseException' that makes it clear that someone has thought about it and decided that all exceptions should be caught, as opposed to it being legacy code or a programming mistake. > > On 2015-05-26 12:26 AM, Terry Reedy wrote: > > > >>> + try: > >>> + encoding, lines = detect_encoding(buffer.readline) > >>> + buffer.seek(0) > >>> + text = TextIOWrapper(buffer, encoding, line_buffering=True) > >>> + text.mode = 'r' > >>> + return text > >>> + except: > >>> + buffer.close() > >>> + raise > >>> > >> > >> Please do not add bare 'except:'. If you mean 'except BaseException:', > >> say so. _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
