Me, either. So I'm going to leave it as a tuple. Unless I find something
while reviewing it tonight, I'm done.
Eric.
On 12/3/2017 3:02 PM, Guido van Rossum wrote:
On second thought I don't care that much.
On Dec 3, 2017 9:07 AM, "Eric V. Smith" <e...@trueblade.com
<mailto:e...@trueblade.com>> wrote:
On 12/3/2017 11:56 AM, Guido van Rossum wrote:
Not sure I like that better. It's an open-ended sequence of
homogeneous types. What's the advantage of a tuple? I don't want
to blindly follow existing APIs.
So people don't modify it, but consenting adults would say "don't do
that". I currently return a new tuple in each call to fields(), but
in the future I might return the same one every time (per class).
I really don't care so much. The only reason I made any change was
because the implementation was returning an OrderedDict, so I was
changing the tests anyway. I'm happy to change it back to a list,
based on the convention of homogeneous types being in a list.
Eric.
On Sun, Dec 3, 2017 at 6:55 AM, Eric V. Smith
<e...@trueblade.com <mailto:e...@trueblade.com>
<mailto:e...@trueblade.com <mailto:e...@trueblade.com>>> wrote:
I've made a minor change: the return type of fields() is now a
tuple, it was a list.
Eric.
On 12/2/2017 9:02 AM, Eric V. Smith wrote:
I've pushed another version of PEP 557. The only
difference is
changing the default value of "order" to False instead
of True.
This matches regular classes: instances can be tested for
equality, but are unordered.
Discussion at
https://github.com/ericvsmith/dataclasses/issues/104
<https://github.com/ericvsmith/dataclasses/issues/104>
<https://github.com/ericvsmith/dataclasses/issues/104
<https://github.com/ericvsmith/dataclasses/issues/104>>
It's already available at
https://www.python.org/dev/peps/pep-0557/
<https://www.python.org/dev/peps/pep-0557/>
<https://www.python.org/dev/peps/pep-0557/
<https://www.python.org/dev/peps/pep-0557/>>
I've updated the implementation on PyPI to reflect this
change:
https://pypi.python.org/pypi/dataclasses/0.3
<https://pypi.python.org/pypi/dataclasses/0.3>
<https://pypi.python.org/pypi/dataclasses/0.3
<https://pypi.python.org/pypi/dataclasses/0.3>>
Eric.
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org <mailto:Python-Dev@python.org>
<mailto:Python-Dev@python.org <mailto:Python-Dev@python.org>>
https://mail.python.org/mailman/listinfo/python-dev
<https://mail.python.org/mailman/listinfo/python-dev>
<https://mail.python.org/mailman/listinfo/python-dev
<https://mail.python.org/mailman/listinfo/python-dev>>
Unsubscribe:
https://mail.python.org/mailman/options/python-dev/eric%2Ba-python-dev%40trueblade.com
<https://mail.python.org/mailman/options/python-dev/eric%2Ba-python-dev%40trueblade.com>
<https://mail.python.org/mailman/options/python-dev/eric%2Ba-python-dev%40trueblade.com
<https://mail.python.org/mailman/options/python-dev/eric%2Ba-python-dev%40trueblade.com>>
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org <mailto:Python-Dev@python.org>
<mailto:Python-Dev@python.org <mailto:Python-Dev@python.org>>
https://mail.python.org/mailman/listinfo/python-dev
<https://mail.python.org/mailman/listinfo/python-dev>
<https://mail.python.org/mailman/listinfo/python-dev
<https://mail.python.org/mailman/listinfo/python-dev>>
Unsubscribe:
https://mail.python.org/mailman/options/python-dev/guido%40python.org
<https://mail.python.org/mailman/options/python-dev/guido%40python.org>
<https://mail.python.org/mailman/options/python-dev/guido%40python.org
<https://mail.python.org/mailman/options/python-dev/guido%40python.org>>
--
--Guido van Rossum (python.org/~guido
<http://python.org/%7Eguido> <http://python.org/%7Eguido>)
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
