2018-01-25 22:46 GMT+01:00 Barry Warsaw <ba...@python.org>: > Why not just auto merge if the PR is approved, CI is all green, and no > additional commits have been pushed?
Merging a PR and approving it should be two different actions. Sometimes, you prefer to wait for 2 approvals before merging. Sometimes, you want to wait until another change is merged. There are many cases. On Gerrit (ex: review.openstack.org), votes and workflow are two different fields. Vote: -2, -1, 0, +1, +2. -2 and +2 votes are reserved to core reviewers. Voting +2 means approving a change. Workflow: -1, 0, +1. -1 means that the change is a work-in-progress. +1 asks to merge the change, once tests pass. Victor _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
