On Sat, Jan 5, 2019 at 11:58 AM Abe Dillon <abedil...@gmail.com> wrote: > You made EMOTE_PATH all caps signifying it's a constant, then added a comment > saying that it "Can be overwritten prior to calling get_emote_list". > > So not only was your naming convention, on its own, insufficient to explain > the API of your code, but you're completely violating PEP-8 because your > using the constancy convention on something that's not constant. That's 100% > counterintuitive. You subvert the one thing that all-caps is supposed to > communicate. >
If "don't change this externally" is the default, why would we have a naming convention meaning "don't change this externally"? I think you're misunderstanding the way that module constants are used in Python. They CAN be overridden. That is part of the point. All-caps does *not* signify "don't override this". ChrisA _______________________________________________ Python-ideas mailing list Python-ideas@python.org https://mail.python.org/mailman/listinfo/python-ideas Code of Conduct: http://python.org/psf/codeofconduct/
