On Tue, Oct 29, 2019 at 12:29 PM Ricky Teachey <ri...@teachey.org> wrote:
> Cool. Sounds like >> >> def with_stem(self, new_stem): >> self.with_name(new_stem + self.suffix) >> >> is the preferred solution. I agree it seems like the right option. >> >> As I said, I don't think it's a big deal either way. A bugs.python.org >> issue with an attached PR implementing (and documenting) this seems >> like the way to go - no big need to debate it. Although it's good that >> we caught the difference in behaviour between the two options - any >> patch adding this should include tests for this particular corner case >> (and any others that you can think of ;-)) >> >> Paul >> > > *(Apologies to Paul who is receiving this a second time)* > > Seems like the right implementation to me. Does anybody disagree that a > bug report with a PR is the way to move forward on this? > Depends if you're okay with the PR potentially being rejected because the idea gets rejected. If you're fine with that then do both, if you're not then I would open the issue to make sure other core devs don't object. > > Also: I've filed bug reports before, but I don't think I've ever filed a > bug report with a PR and with tests against core python. Is there a link > that might help with learning the process, with an eye to how to setup and > run the test correctly for the project...? I believe I've already signed > the usage agreement and that sort of thing. > https://devguide.python.org/ should have everything you need (and if it doesn't then please submit a PR to fix it 😉). -Brett > > _______________________________________________ > Python-ideas mailing list -- python-ideas@python.org > To unsubscribe send an email to python-ideas-le...@python.org > https://mail.python.org/mailman3/lists/python-ideas.python.org/ > Message archived at > https://mail.python.org/archives/list/python-ideas@python.org/message/MEARZKOEGHTVSUOQJQSJ2ZPVDFVXSR4B/ > Code of Conduct: http://python.org/psf/codeofconduct/ >
_______________________________________________ Python-ideas mailing list -- python-ideas@python.org To unsubscribe send an email to python-ideas-le...@python.org https://mail.python.org/mailman3/lists/python-ideas.python.org/ Message archived at https://mail.python.org/archives/list/python-ideas@python.org/message/IGLA6SDR7ZTP6ZTJTTMTSJRIEC23HA5V/ Code of Conduct: http://python.org/psf/codeofconduct/
