On 2010-11-03, Ben Finney <ben+pyt...@benfinney.id.au> wrote:
> I would do the same, but fix the indentation. Making
> indentation depend on the *length* of the previous line is
> needlessly making a maintenance burden.
>
> Instead, I'd do::
>
> styles = [
> ("normal", "image", MainWindow.ColorsNormalList),
> ("highlighted", "highlight", MainWindow.ColorsHighlightedList),
> ("selected", "select", MainWindow.ColorsSelectedList)]
Agreed, except cute stuff like putting those three items in
columns is just as bad.
Code should be utilitarian rather than ornate, Shaker rather than
Victorian.
--
Neil Cerutti
--
http://mail.python.org/mailman/listinfo/python-list
