> On Jun 20, 2015, at 2:10 AM, Tormod Volden <lists.tor...@gmail.com> wrote: > > On Fri, Jun 19, 2015 at 4:12 PM, Hermann Hamann wrote: >> I am sorry, but I am too old and too stupid to learn on the fly how to use a >> github pull request >> to push some files. >> >> So I use the stone age way to attach the modified files core.py and >> libusb1.py to this mail, hoping, >> that some kind soul will find them and treat them as required. > > Hermann, > > What version of pyusb are your changes based on? Without knowing this, > it is difficult to figure out exactly what are your changes. > > You are giving the maintainer a lot of extra work by just dumping your > files on him. At least, use a "diff" utility to make a > machine-readable diff instead. BTW, the original "diff" was made in > the seventies, so age is no excuse. > > Regards, > Tormod > > ------------------------------------------------------------------------------ > _______________________________________________ > pyusb-users mailing list > pyusb-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/pyusb-users
Hermann, Presuming that you used git to clone the source repository there is one of the few basic git commands to get a properly formatted patch that tracks the source revision. Please use git format-patch to generate diffs based upon the checkout that you worked against. `git format-patch origin/master` As for pull requests in github, you are not too stupid nor too old. Your self deprecation begs for mockery from others. I accept no ageism, my grandmother was an avid computer user, that was self taught when she was 62, on a 8088 IBM PC clone. 1. Fork the pyusb repository. 2. Commit your changes to a branch in your new fork on your computer. 3. Push your changes to in the forked repository on github. 4. Submit a pull request for that new branch against the pyusb repository. Please refer to this documentation from github. https://help.github.com/articles/using-pull-requests/ <https://help.github.com/articles/using-pull-requests/> Steve
------------------------------------------------------------------------------
_______________________________________________ pyusb-users mailing list pyusb-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pyusb-users