jayvdb added a comment.
In https://phabricator.wikimedia.org/T115428#2069993, @darthbhyrava wrote: > According to Beautiful Soup's documentation ( https://goo.gl/HfQifz ) we need to change the import statements and check for specific method names while porting to bs4. > This can be easily changed in the two respective scripts. > > But how can I enusre bs4 //is// installed in the first place See setup.py attributes `script_deps` and `extra_deps` member `html` , and tests/script_tests.py attribute `script_deps` which uses `BeautifulSoup` which needs to be changed to `bs4` after the two scripts have been fixed to use bs4. requirements.txt also installs the necessary dependencies, and it already installs bs4. > and where do I add the test script for getLicense()? Add a unittest compliant test in a new test module `tests/panoramiopicker_tests.py`. TASK DETAIL https://phabricator.wikimedia.org/T115428 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: AbdealiJK, darthbhyrava, StudiesWorld, XZise, Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, tahteche _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
