AbdealiJK added a comment.
@darthbhyrava I notice that you have created a new gerrit Change <https://gerrit.wikimedia.org/r/#/c/288871/> with a different Change-Id. This is not normally recommended, and it's better to create a new PatchSet in the previous gerrit change. Read more ... <https://www.mediawiki.org/wiki/Gerrit/Tutorial#Prepare_to_work_with_Gerrit> **Regarding `StringIO`** - `StringIO` or `io.BytesIO` needs to be used in py2 and `io.StringIO` should be used in py3. Check `tests/ui_tests.py:89` <https://phabricator.wikimedia.org/diffusion/PWBC/browse/refs%252Fchanges%252F91%252F286791%252F5/tests/ui_tests.py;3c8c5eae24a147a5149be75c305bf7b9649a2830$89>: $ git grep StringIO pywikibot/compat/query.py: res_dummy = io.StringIO() pywikibot/data/wikistats.py:from io import BytesIO, StringIO pywikibot/data/wikistats.py: f = StringIO(data.decode('utf8')) scripts/panoramiopicker.py:import StringIO scripts/panoramiopicker.py: Download the photo and store it in a StrinIO.StringIO object. scripts/panoramiopicker.py: return StringIO.StringIO(imageFile) scripts/script_wui.py:from io import StringIO scripts/script_wui.py: buffer = StringIO() tests/ui_tests.py: """Handler for a StringIO or BytesIO instance able to patch itself.""" tests/ui_tests.py: Create a new stream with a StringIO or BytesIO instance. tests/ui_tests.py: self._stream = io.StringIO() if not PY2 else io.BytesIO() tests/ui_tests.py: self.stream = io.StringIO() **script_deps** - I do not think this is needed anymore, rather you need to use the `@requires_module('bs4')` decorator in your tests. But I'll let @jayvdb or others confirm this as i am not sure. TASK DETAIL https://phabricator.wikimedia.org/T115428 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, AbdealiJK Cc: TerraCodes, gerritbot, AbdealiJK, darthbhyrava, StudiesWorld, XZise, Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, Lewizho99, Mdupont, Maathavan _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
