jayvdb created this task. TASK DESCRIPTION As a result of the changes for https://phabricator.wikimedia.org/T89670, `test_no_qualifiers` now fails, and there is now no way to tell if `precision` is missing, and it was valid for `precision` to be `None`. ====================================================================== ERROR: test_no_qualifiers (tests.pagegenerators_tests.TestItemClaimFilterPageGenerator) Test ItemClaimFilterPageGenerator on sample page without qualifiers. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/build/jayvdb/pywikibot-core/tests/pagegenerators_tests.py", line 664, in test_no_qualifiers self._simple_claim_test('P625', '21,78', None, True) File "/home/travis/build/jayvdb/pywikibot-core/tests/pagegenerators_tests.py", line 617, in _simple_claim_test pages = set(gen) File "/home/travis/build/jayvdb/pywikibot-core/pywikibot/pagegenerators.py", line 1462, in filter if cls.__filter_match(page, prop, claim, qualifiers) and not negate: File "/home/travis/build/jayvdb/pywikibot-core/pywikibot/pagegenerators.py", line 1436, in __filter_match if page_claim.target_equals(claim): File "/home/travis/build/jayvdb/pywikibot-core/pywikibot/page.py", line 4591, in target_equals if self.target.precision is not None: File "/home/travis/build/jayvdb/pywikibot-core/pywikibot/__init__.py", line 358, in precision raise ValueError('No values set for dim or precision') ValueError: No values set for dim or precision
TASK DETAIL https://phabricator.wikimedia.org/T129834 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, jayvdb Cc: Multichill, Aklapper, pywikibot-bugs-list, Ricordisamoa, darthbhyrava, jayvdb _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
