darthbhyrava added a comment.

  This is interesting, since `$ nosetests -v` didn't 
<http://paste.ubuntu.com/15384636/> throw this error when I ran it, but `$ 
nosetests -v tests.pagegenerators_tests` actually //did. 
<http://paste.ubuntu.com/15384673/>//
  
  Anyways, in __init__.py, in the initial documentation of the property 
`precision`, it is mentioned that:
  
  > When no precision and no self._dim exists, None is returned.
  
  But in the doc string that I wrote for `precisionToDim`, we went with:
  
  > When neither dim nor precision are set, ValueError is thrown.
  
  and I returned ValueErrors in both the functions when both dim and precision 
were `None`.
  
  Removing the ValueError there and simply returning a `None` whenever both 
precision and dim are `None`, (along with necessary changes in wikibase_tests) 
as was the case in the `precision` property,  solves the  issue, and returns no 
errors for `$ nosetests -v tests.pagegenerators_tests` //and// `$ nosetests -v 
tests.wikibase_tests`.

TASK DETAIL
  https://phabricator.wikimedia.org/T129834

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: darthbhyrava
Cc: Multichill, Aklapper, pywikibot-bugs-list, Ricordisamoa, darthbhyrava, 
jayvdb



_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to