jayvdb added a comment.

  @AbdealiJK , on  https://phabricator.wikimedia.org/T134337 , you wrote "The 
[current] method id actually invalid because python doesn't guarantee that the 
variable `_tk_error` exists outside the except statement."
  
  That is the reason behind https://github.com/pyflakes/pyflakes/pull/59 .  
  `./scripts/flickrripper.py` and `./pywikibot/botirc.py` are not effectively 
tested on Python 3, and are not a high priority.
  
  However `./pywikibot/diff.py` is a central component, and is used by the 
Python 3 tests, so it should be possible to create a test case that proves that 
the current use of `bserror` can cause an `UnboundLocalError`.

TASK DETAIL
  https://phabricator.wikimedia.org/T134336

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: AbdealiJK, hashar, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, 
Mdupont



_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to