AbdealiJK added a subscriber: Mpaa. AbdealiJK added a comment.
@jayvdb irrespective of whether this is a false positive, I think it should be changed in diff.py because of convention. I remember when trying to do a similar thing in https://phabricator.wikimedia.org/T123092 @Mpaa gave the gerrit comment <https://gerrit.wikimedia.org/r/#/c/277207/6/pywikibot/tools/__init__.py>: > This is more in line with implementation of the same kind in other modules. Although I do agree it would be good to have a testcase for it. (I have no idea how to test it though !) TASK DETAIL https://phabricator.wikimedia.org/T134336 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Mpaa, AbdealiJK, hashar, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, Mdupont _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
