Magul added a comment.

I was thinking about such solution and figure out that I want to go with bolder move here. I'm in the middle fo rewriting whole test module here.

I will make separate testes for every site, create decorator that will embed test in for loop (in such manner that we will be able to retry test for given number of time).

I also removed this whole unnecessary logic with set operations - we don't need that, as we just want to test if site is detect correclty and it is perfectly done by one site, one unitttest aproach.

In the and I also removed whole test_IWM tjhing, beacuse that wasn't test, there were no assertions at all, it was just iterating over some set of sites and populating few sets (all, pass, error, fail etc,) and at the end printing some simple statistics. It was not able to fail, so there is no reason to call it on every change in CI environment.

BTW I'm merging Your change, as it is the right direction for PWB to raise this error here, but I believe it's falisifying test here (cause this page exists and what does it mean, that we are skiping test on ServerError at all?)


TASK DETAIL
https://phabricator.wikimedia.org/T151368

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Magul
Cc: gerritbot, Dalba, pywikibot-bugs-list, Aklapper, Magul, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to