| Magul added a comment. |
In T151368#2871917, @Lokal_Profil wrote:Is there a particular reason/need to have lojban.org in the tests? If there isn't then simply removing it could make sense.
No, there is no more sophisticated reason, than that it was there already. I'm removing this test.
Also since I'm on mobile and can't leave this content in gerrit:
- You have referenced the wrong parameter in the docstring for the decorator.
Fixed in new patch. Also adding epydoc description for it.
- Many of the new docstrings don't include epydoc fields for their parameters.
I feel, that there is not much value in adding parameteres infromations here. I would like to add them to aseertSite and assertNoSite but all tests accept self and return None or raises AssertionError (or at least should). Do You think, that we should copy it over to all tests' docstrings?
Other than that and the 100 retries for lojban.org the patch looks good and feels like a clear improvement over the old structure.
New patch with Your comments uploaded.
Cc: Lokal_Profil, gerritbot, Dalba, pywikibot-bugs-list, Aklapper, Magul, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
