Magul added a comment.

Ok, just after merge and failing builds on Travis I figure out some shortcommings of new aproach: we are asserting if site is instance of MWSite, but doesn't catch all exception, that can happened during testing assertion, so newly created decorator doesn't swallow AssertionError 10 times, it just fails on any of AttributeError, ConnectionError, RuntimeError, ServerError, Timeout at the first try.

I will publish patch today's evening.


TASK DETAIL
https://phabricator.wikimedia.org/T151368

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Magul
Cc: Lokal_Profil, gerritbot, Dalba, pywikibot-bugs-list, Aklapper, Magul, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to