| Dalba added a comment. |
It feels odd to me for a replace_in_place function to have an add_only parameter, because when add_only is True it does not look like a replacement anymore.
I'd rather factor out some part of the logic into a private function and then use it to create a new add_category function.
TASK DETAIL
EMAIL PREFERENCES
To: eflyjason, Dalba
Cc: Dalba, Framawiki, gerritbot, Xqt, Aklapper, eflyjason, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Masti, Alchimista, Rxy
Cc: Dalba, Framawiki, gerritbot, Xqt, Aklapper, eflyjason, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
