[Pywikipedia-bugs] [Maniphest] [Created] T196838: VCR tests sometimes create cassettes for the default wiki, adding untracked files to git status

[Dalba]

Dalba created this task. Dalba added projects: Pywikibot-tests, Pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION

Steps to reproduce:

0. Make sure there is nothing to commit

1. Edit user-config.py
   1. Set mylang to test
   2. Set family to wikidata
2. Run python -m unittest tests.api_tests.TestCachedRequest
3. Get git status:

$ git status
On branch master
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        tests/cassettes/wikidata.test/TestCachedRequest.test_normal_use.yaml

nothing added to commit but untracked files present (use "git add" to track)

Running a dry test has added a new undesired file. It's annoying to have these files created every time the developer runs the tests. It could be committed accidentally if they use git add -A. Note that .yaml files may contain private information which leads to security/privacy risks for the developer.

Running VCR tests should not have the side effect of creating new cassettes (except when we developer is adding new tests of-course).

Maybe we should not have VCR tests configured for DefaultSiteTestCase?

TASK DETAIL

https://phabricator.wikimedia.org/T196838

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dalba
Cc: Aklapper, pywikibot-bugs-list, Dalba, Sc4s2cg, Magul, Tbscho, MayS, Salgo60, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs