| Vvjjkkii renamed this task from "VCR tests sometimes create cassettes for the default wiki, adding untracked files to git status" to "lbbaaaaaaa". Vvjjkkii triaged this task as "High" priority. Vvjjkkii removed a subscriber: Aklapper. Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, JADE, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team. Vvjjkkii updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
Steps to reproduce:
1. Make sure there is nothing to commit
2. Edit user-config.py
1. Set `mylang` to `test`
2. Set `family` to `wikidata`
3. Run `python -m unittest tests.api_tests.TestCachedRequest`
4. Get git status:
```
$ git status
On branch master
Untracked files:
(use "git add <file>..." to include in what will be committed)
tests/cassettes/wikidata.test/TestCachedRequest.test_normal_use.yaml
nothing added to commit but untracked files present (use "git add" to track)
```
Running a dry test has added a new undesired file. It's annoying to have these files created every time the developer runs the tests. It could be committed accidentally if they use `git add -A`. Note that `.yaml` files may contain private information which leads to security/privacy risks for the developer.
Running VCR tests should not have the side effect of creating new cassettes (except when we developer is adding new tests of-course).
Maybe we should not have VCR tests configured for `DefaultSiteTestCase`?26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e
1. Make sure there is nothing to commit
2. Edit user-config.py
1. Set `mylang` to `test`
2. Set `family` to `wikidata`
3. Run `python -m unittest tests.api_tests.TestCachedRequest`
4. Get git status:
```
$ git status
On branch master
Untracked files:
(use "git add <file>..." to include in what will be committed)
tests/cassettes/wikidata.test/TestCachedRequest.test_normal_use.yaml
nothing added to commit but untracked files present (use "git add" to track)
```
Running a dry test has added a new undesired file. It's annoying to have these files created every time the developer runs the tests. It could be committed accidentally if they use `git add -A`. Note that `.yaml` files may contain private information which leads to security/privacy risks for the developer.
Running VCR tests should not have the side effect of creating new cassettes (except when we developer is adding new tests of-course).
Maybe we should not have VCR tests configured for `DefaultSiteTestCase`?26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e
TASK DETAIL
EMAIL PREFERENCES
To: Vvjjkkii
Cc: Framawiki, pywikibot-bugs-list, Dalba, AndyTan, Zylc, 1978Gage2001, herron, pan199312, Chicocvenancio, alanajjar, Magul, Tbscho, MayS, Lea_WMDE, Mattias_Ostmar-WMSE, Mdupont, JJMC89, Jseddon, Ryuch, Mkdw, RuyP, Avicennasis, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Snowolf, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Masti, revi, scfc, Alchimista, He7d3r, Romaine, Mbch331, Rxy, Jay8g, Glaisher, Krenair, chasemp, Aklapper
Cc: Framawiki, pywikibot-bugs-list, Dalba, AndyTan, Zylc, 1978Gage2001, herron, pan199312, Chicocvenancio, alanajjar, Magul, Tbscho, MayS, Lea_WMDE, Mattias_Ostmar-WMSE, Mdupont, JJMC89, Jseddon, Ryuch, Mkdw, RuyP, Avicennasis, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Snowolf, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Masti, revi, scfc, Alchimista, He7d3r, Romaine, Mbch331, Rxy, Jay8g, Glaisher, Krenair, chasemp, Aklapper
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
