| matej_suchanek removed a project: Patch-For-Review. matej_suchanek added a comment. |
Another problem I can see is that filter_unique (inside GenFact it is self._filter_unique) is used twice: it's provided to RecentChangesPageGenerator (line 821) and also used for dupfiltergen = self._filter_unique(gensList) (line 532). This means there are two same independent sets, one of which is redundant.
Could somebody verify the last sentence is a valid statement?
TASK DETAIL
EMAIL PREFERENCES
To: Xqt, matej_suchanek
Cc: gerritbot, zhuyifei1999, Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan
Cc: gerritbot, zhuyifei1999, Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
